Fixed #21 #23
Open
Fixed #21 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marudy
reviewed
Mar 18, 2019
marudy
reviewed
Mar 18, 2019
marudy
reviewed
Mar 18, 2019
There was a problem hiding this comment.
Hey @AhmedMKamal thanks again for the PR. In this PR you have some changes that are now merged to master. Can you merge master to this branch to eliminate them and me have a second review? Also added a few comments. Cheers bud
|
Hey, @marudy your comments have been resolved, but I can't sync this brunch with you updated master brunch I think I have to reopen new PR or just merge this one as is. |
dikamilio
reviewed
Aug 16, 2019
| Dimensions.removeEventListener('change', () => {}); | ||
| const removeOrientationListener = orientationChangeHandler => { | ||
| // Warn if the original handler not passed. | ||
| if (orientationChangeHandler) { |
There was a problem hiding this comment.
this should be oposite condition -> if (!orientationChangeHandler) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As lschuft mentioned it's not a good approach to meth the component's props, instead the
listenOrientationChangemay return the original handler, store it somewhere and push it back toremoveOrientationListener